Skip to content

pdns: emit rrsig on alias responses#17565

Open
devsnek wants to merge 1 commit into
PowerDNS:masterfrom
devsnek:dnssec-alias
Open

pdns: emit rrsig on alias responses#17565
devsnek wants to merge 1 commit into
PowerDNS:masterfrom
devsnek:dnssec-alias

Conversation

@devsnek

@devsnek devsnek commented Jun 11, 2026

Copy link
Copy Markdown

Short description

Refs: #3838

Implement signing of ALIAS records. I'm new to the codebase so please let me know anything I've overlooked :)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls

coveralls commented Jun 11, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27364741802

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+11.4%) to 71.088%

Details

  • Coverage increased (+11.4%) from the base build.
  • Patch coverage: 20 uncovered changes across 1 file (19 of 39 lines covered, 48.72%).
  • 21614 coverage regressions across 291 files.

Uncovered Changes

File Changed Covered %
pdns/dnsproxy.cc 38 18 47.37%
Total (2 files) 39 19 48.72%

Coverage Regressions

21614 previously-covered lines in 291 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
pdns/lua-record.cc 809 0.17%
pdns/dnsdistdist/dnsdist-lua.cc 741 52.0%
pdns/recursordist/rec-main.cc 688 65.05%
pdns/recursordist/syncres.cc 581 81.42%
modules/lmdbbackend/lmdbbackend.cc 571 72.0%
pdns/recursordist/rec_channel_rec.cc 563 35.34%
pdns/dnsdistdist/dnsdist.cc 541 68.36%
pdns/auth-main.cc 520 50.03%
pdns/recursordist/ws-recursor.cc 502 22.03%
pdns/tcpiohandler.cc 474 59.89%

Coverage Stats

Coverage Status
Relevant Lines: 171278
Covered Lines: 133432
Line Coverage: 77.9%
Relevant Branches: 81888
Covered Branches: 46538
Branch Coverage: 56.83%
Branches in Coverage %: Yes
Coverage Strength: 6276044.79 hits per line

💛 - Coveralls

Signed-off-by: snek <the@snek.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants